Add reference built in listener for kernel.response event in >= 3.1 #7755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jean-pasqualini, thanks for opening that PR. Note that 3.1 is not maintained anymore and merging your PR in 3.2 will be enough since mergers will eventually merge 3.2 in master afterward. |
jean-pasqualini
force-pushed
the
fix-built-in-listener
branch
from
40f1580 to
1354279
Compare
|
thanks @HeahDude, I rebased on branch 3.2. |
|
Where are the labels of this pr? |
|
Thank you @jean-pasqualini. |
xabbuh
added a commit
that referenced
this pull request
Apr 8, 2017
… in >= 3.1 (jean-pasqualini) This PR was merged into the 3.2 branch. Discussion ---------- Add reference built in listener for kernel.response event in >= 3.1 The class `RequestDataCollector` listen event `kernel.response` in >= 3.1 version of symfony. See : https://github.com/symfony/http-kernel/blob/3.1/DataCollector/RequestDataCollector.php#L313 Commits ------- 1354279 add reference built in listener for kernel.response event in >=3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
RequestDataCollectorlisten eventkernel.responsein >= 3.1 version of symfony.See : https://github.com/symfony/http-kernel/blob/3.1/DataCollector/RequestDataCollector.php#L313